feat!: validate all locales by default - #17879
Draft
paulpopus wants to merge 47 commits into
Draft
Conversation
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge this first: #17557
Summary
The Publish button now checks every locale before it publishes a localized document. Before this change, publishing could succeed even when another locale had invalid or missing data. Now the button validates every locale first and blocks the publish action when any locale fails.
Why
A publish action could make one locale public while a sibling locale stayed broken. Nobody noticed the broken locale, because publishing never checked it. This change stops a publish action from hiding a problem in a locale nobody is looking at.
How
Breaking changes
Publishing a document with localized fields can now fail when a locale other than the active one has invalid or missing required data. Before this change, a publish action always succeeded regardless of other locales' data. Projects with existing invalid data in a non-active locale must fix that data before they can publish again.
Related work
This change depends on #17557. That PR adds the on-demand validation Local API, REST endpoints, and GraphQL mutations this change calls.