Skip to content

Expand webhook payload into form fields on view pages - #2578

Merged
lancepioch merged 1 commit into
mainfrom
fix/server-webhook-payload-2570
Sep 17, 2026
Merged

lancepioch merged 1 commit into
mainfrom
fix/server-webhook-payload-2570

Conversation

@lancepioch

Copy link
Copy Markdown
Member

The webhook view pages skipped the type schema's fill mutation, so payload backed fields (like the Discord plugin's) rendered empty when viewing a webhook. This adds the fill hook to both view pages and test coverage for the server panel webhook pages, including payload persistence on create.

The save half of #2570 was already fixed by #2498, these tests pin that too.

The view pages filled the form without the type schema's fill mutation, so
payload-backed fields (like the Discord plugin's) rendered empty. Adds the
MutatesWebhookFormData fill hook to both view pages and test coverage for
the server panel webhook pages, including payload persistence on create.
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 1172430b-107a-4d65-98df-28ccab3911e2

📥 Commits

Reviewing files that changed from the base of the PR and between fdb519e and 0095805.

📒 Files selected for processing (4)
  • app/Filament/Admin/Resources/Webhooks/Pages/ViewWebhookConfiguration.php
  • app/Filament/Server/Resources/Webhooks/Pages/ViewWebhook.php
  • tests/Filament/Admin/WebhookCrudTest.php
  • tests/Filament/Server/WebhookCrudTest.php

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Webhook view pages now expand stored webhook payload data before filling form fields. New admin and server tests cover payload handling during creation, editing, and viewing.

Changes

Webhook form hydration

Layer / File(s) Summary
View page payload mutation
app/Filament/Admin/Resources/Webhooks/Pages/ViewWebhookConfiguration.php, app/Filament/Server/Resources/Webhooks/Pages/ViewWebhook.php
Both view pages use MutatesWebhookFormData and delegate mutateFormDataBeforeFill to mutateWebhookDataBeforeFill.
Payload hydration coverage
tests/Filament/Admin/WebhookCrudTest.php, tests/Filament/Server/WebhookCrudTest.php
Tests register a collapsing webhook schema and verify payload persistence, edit-form hydration, and view-form hydration for admin and server webhooks.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 00958

Webhook payload-backed fields are hydrated on both view pages, with tests covering the intended workflows. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 8.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: expanding webhook payload data into form fields on view pages.
Description check ✅ Passed The description accurately explains the missing fill mutation, the affected view pages, and the added test coverage.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lancepioch
lancepioch merged commit 260333d into main Sep 17, 2026
17 checks passed
@lancepioch
lancepioch deleted the fix/server-webhook-payload-2570 branch September 17, 2026 18:41
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants