Expand webhook payload into form fields on view pages - #2578
Conversation
The view pages filled the form without the type schema's fill mutation, so payload-backed fields (like the Discord plugin's) rendered empty. Adds the MutatesWebhookFormData fill hook to both view pages and test coverage for the server panel webhook pages, including payload persistence on create.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughWebhook view pages now expand stored webhook payload data before filling form fields. New admin and server tests cover payload handling during creation, editing, and viewing. ChangesWebhook form hydration
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to Webhook payload-backed fields are hydrated on both view pages, with tests covering the intended workflows. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The webhook view pages skipped the type schema's fill mutation, so payload backed fields (like the Discord plugin's) rendered empty when viewing a webhook. This adds the fill hook to both view pages and test coverage for the server panel webhook pages, including payload persistence on create.
The save half of #2570 was already fixed by #2498, these tests pin that too.