poll: fetch method ptr directly#22816
Merged
Girgias merged 2 commits intoJul 20, 2026
Merged
Conversation
Rather than going through a whole callability check via call_user_function() we can grab the known method pointer and call it directly. This removes some allocations
Girgias
marked this pull request as ready for review
July 19, 2026 23:03
ndossche
reviewed
Jul 20, 2026
ndossche
reviewed
Jul 20, 2026
Member
|
Ah think this is actually dead code anyway as I disallowed user space creation so it's more leftover from the time when I was using abstract PollHandle class but then it got changed to the marker interface that userpace cannot implement. It might need some clean up though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than going through a whole callability check via call_user_function() we can grab the known method pointer and call it directly.
This removes some allocations