Repository navigation
Fix orion start up race condition - #406
Merged
Merged
Conversation
vahidhashemian
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Kafka node registration race on Orion startup
Problem
When Orion starts, the cluster is registered with
ClusterManagerright after its sensors are started, but before the firstKafkaBrokerSensorrun (describeCluster) has returned. During that window, agent heartbeats hitting/registercan create broker nodes viaCluster.updateNodeFromAgentHeartbeat, using the agent-reportedNodeInfoas the node'scurrentNodeInfo.Fix
KafkaClusteroverridesupdateNodeFromAgentHeartbeatand defers registration of new nodes until the first broker sensor run has populated the node map. Heartbeats for nodes that are already known (added by the sensor or restored from cluster state) are processed as before.KafkaBrokerSensorcallsmarkBrokerSensorCompleted()right after brokers are added to the node map, so a later failure (e.g. controller lookup) doesn't keep registrations blocked.null(no command), which agents already handle; they retry on their next heartbeat. Metrics from the heartbeat are still published.