Repository navigation
Conversation
VS Code promise-cancellation races surface as Canceled rejections (e.g. a
pending ptyHost resolved-variables RPC cancelled on extension-host restart).
Treating them as fatal crashed the worker on every restart, and the respawn
loop re-triggered the same race. Canceled rejections (by name or message) are
now logged and ignored; all others still forward { type: error } to the
parent and exit 1, so the respawn contract is unchanged.
Adds lib/worker.test.ts: forks the actual worker.mjs against a stubbed dist
entry in a temp dir and covers both Canceled shapes plus the forward-and-exit
path end-to-end over IPC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VS Code promise-cancellation races surface as Canceled rejections (e.g. a pending ptyHost resolved-variables RPC cancelled on extension-host restart). Treating them as fatal crashed the worker on every restart, and the respawn loop re-triggered the same race. Canceled rejections (by name or message) are now logged and ignored; all others still forward { type: error } to the parent and exit 1, so the respawn contract is unchanged.
Adds lib/worker.test.ts: forks the actual worker.mjs against a stubbed dist entry in a temp dir and covers both Canceled shapes plus the forward-and-exit path end-to-end over IPC.