Repository navigation
feat(skills): ship the skills as a plugin with its own marketplace - #162
Merged
Merged
Conversation
…arketplace plugin.json lists the four skill folders, so nothing moves; the CX agents skill stays out. marketplace.json lets the repo be added as a marketplace.
Plugin installs stay on the manifest's version until it changes. make test-release-notes now fails until it matches the CHANGELOG top, and RELEASING.md says to bump it in the CHANGELOG PR.
With the repository root as the plugin, the whole repo was packaged: Go code, tests and scripts. plugin/ now holds the manifest and copies of the four product skills; make plugin-skills refreshes them and a test fails until they match the bundled skills. The marketplace entry points at ./plugin. The manifest also gets the directory's documentation, support, privacy and terms links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ships the four product skills as a plugin, with the repo as its marketplace, so they can be installed in one step and submitted to the plugin directory.
plugin.json(plivo) listscli-skill,sip-trunking-skill,audio-streaming-skillandvoice-xml-skillin place; the CX agents skill stays out.marketplace.jsonmakes the repo a marketplace:/plugin install plivo --marketplace plivo/plivo-cli.versionfollows the CLI release (1.3.0 now): installs stay on that version until it changes.make test-release-notesfails until it matches the CHANGELOG top, and RELEASING.md says to bump it in the CHANGELOG PR.Checked:
plugin validate --strictpasses on the repo and on the manifest; added the branch as a marketplace and installedplivo@plivoin an isolated config: 4 skills load (cli, sip-trunking, audio-streaming, voice-xml); release-notes check fails with a mismatched version;make fmt vet test test-tap test-release-notes;make docsclean.