Repository navigation
docs(skill): describe the v1.3.1 fixes in the CLI, audio-streaming, voice-xml and SIP skills - #176
Merged
Merged
Conversation
…pi redirects, and the voice, app and SIP fixes in the CLI skill
…in the audio-streaming skill
… SIP trunking skill
From v1.3.1 an HTTP error from plivo api carries the code and exit code a typed command gives it. The skill keeps the older behaviour for older installs and points to status_code, which both versions set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings four skills in line with the v1.3.1 fixes (#171-#174, and the
plivo apierror codes from #177; merge after #177). Each changed line keeps the older behaviour under "before v1.3.1", so the skills stay right on older installs.campaigns updateandconferences stop-recordjoin the spend and destructive lists;--dry-runcovers local changes; tokens and passwords read[REDACTED];--machine-detection,--stream-status-callback,applications delete --cascade=false,plivo apitrailing slash, redirects and error codes, SIP user part.calls makedefaults to POST, except for the demo answer URL.cmd/skill_hashes.gois regenerated withmake skill-hashes, which also adds two older shipped versions that were missing.Size
Added lines by type, blank lines excluded. Comments counts comment lines in non-test code.
Removed: 30 lines.