Repository navigation
fix(sip): no SRV warning when the record names the address tested - #182
Merged
Merged
Conversation
sip test warned "points to <host>:5060; this test probes <host> itself" when a host's SIP SRV record names the host on the port tested, as sip.rtc.elevenlabs.io and phone.plivo.com do. SRV and A/AAAA reach the same address there. The warning now names the first record that points elsewhere, so a self record listed first no longer hides another target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sip testno longer warns about a SIP SRV record that names the host itself on the port tested (assip.rtc.elevenlabs.ioandphone.plivo.compublish): SRV and A/AAAA reach the same address there.Size
Added lines by type, blank lines excluded. Comments counts comment lines in non-test code.
Removed: 21 lines. Tests include 2 comment lines.