Fix Custom Dropdown filtering in table questions - #46
Open
UncleTomsCabi wants to merge 3 commits into
Open
Conversation
When using GLPI Custom Dropdowns inside table questions, all dropdown definitions display the same combined list of values. This happens because all custom dropdowns use the same database table (`glpi_dropdowns_dropdowns`), but the current implementation does not apply the system criteria that distinguish each dropdown definition. ## Solution This change updates the table question implementation to correctly filter Custom Dropdown values by applying the item's `getSystemSQLCriteria()` when: - loading dropdown options; - resolving stored values. As a result, each Custom Dropdown now displays only the values that belong to its own definition. Before <img width="290" height="339" alt="Снимок экрана 2026-07-21 143100" src="https://github.com/user-attachments/assets/fc015b93-514c-4d16-84e2-0909d5e6e3a1" /> <img width="211" height="335" alt="Снимок экрана 2026-07-21 143054" src="https://github.com/user-attachments/assets/04f9cd49-92bb-42f2-97ed-4e8b675d4367" /> After <img width="226" height="238" alt="Screenshot 2026-07-31 163806" src="https://github.com/user-attachments/assets/7da6c20d-1124-44b2-a6b1-5f69ef69c6e1" /> <img width="250" height="266" alt="Screenshot 2026-07-31 163809" src="https://github.com/user-attachments/assets/56dcdc8f-2074-4845-aa97-d704016fdd77" />
Rom1-B
requested changes
Aug 7, 2026
Rom1-B
left a comment
Rom1-B
left a comment
Contributor
There was a problem hiding this comment.
Please update CHANGELOG, fix lint and add test cases.
- Add regression tests for Custom Dropdown filtering - Update CHANGELOG - Fix PHP-CS-Fixer formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using GLPI Custom Dropdowns inside table questions, all dropdown definitions display the same combined list of values.
This happens because all custom dropdowns use the same database table (
glpi_dropdowns_dropdowns), but the current implementation does not apply the system criteria that distinguish each dropdown definition.Solution
This change updates the table question implementation to correctly filter Custom Dropdown values by applying the item's
getSystemSQLCriteria()when:As a result, each Custom Dropdown now displays only the values that belong to its own definition.
Before
After