Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node#toStringandContainer#_stringifybuild each result with an array andjoin(""). This change uses string concatenation instead.Container#_stringifystill skipsnullandundefinedchild results, asjoindid. The output does not change.dist, Node.js 24.15.0)toString(), 617 parsed selectors, losslesstoString(), 617 parsed selectors, lossytoString(), 300 small trees built with the node constructorsprocessSync, 1000 empty and one-token selectorsprocessSyncwith a transform that removes and adds nodesprocessSync, 617 selectors, losslessprocessSync, 617 selectors, lossyI measured no slowdown on 20 benchmarks. These include Bootstrap and Tailwind selectors,
:is,:hasand attribute selectors, escapes, invalid selectors, a long selector list, and walks. I used 12 interleaved rounds and a Mann-Whitney test (Apple M2 Max).Testing:
npm testpasses (1076 tests).node --test src/__tests__/*.mjsalso passes on Node.js 20.20.2. On Node.js 16.20.2,attributes-deprecations.mjsfails with and without this change.toString()output and errors were identical for every one.