chore: follow the latest TypeScript repository template - #453
Merged
Merged
Conversation
3 tasks
angeloashmore
force-pushed
the
claude/busy-archimedes-s3umeo-template
branch
from
September 18, 2026 19:19
42cc46c to
099d73f
Compare
angeloashmore
added a commit
that referenced
this pull request
Sep 18, 2026
Resolves: <!-- GitHub or Linear issue (e.g. #123, DT-123) --> ### Description Updates all dependencies and dev dependencies to their latest versions. **This drops Node.js 20.** Vitest 5 needs `^22.12.0 || ^24.0.0 || >=26.0.0` and tsdown needs `^22.18.0 || ^24.11.0 || >=26.0.0`. `engines.node` becomes `>=22` and the test matrix becomes 22 and 24. #453 adds Node.js 26, which is a separate change. Small source changes were needed to keep the suite green: - TypeScript 7 infers `unknown` for the rest properties of a union, so the destructured migration image in `resolveMigrationImage()` is annotated. - `oxfmt` reformats two files the previous version left alone. - `@prismicio/types-internal` stays on 3.x. Version 4 is a rewrite, and migrating to it means two decisions about this package's public API: whether the `CustomTypeModel*` types gain `fieldset`, `schema`, `format`, `legacyPaths` and `display`, and whether their `readonly` arrays become mutable. #454 has the detail. **CI note:** `test (Node.js 22)` and `test (Node.js 24)` also fail on `master` — the Prismic API is flaky right now and the network-dependent tests in `test/client.test.ts` time out. `npm run lint`, `npm run types`, `npm run build`, and `npm run unit` all pass locally on this branch. ### Checklist - [ ] If my changes require tests, I added them. - [ ] If my changes affect backward compatibility, it has been discussed. - [ ] If my changes require an update to the CONTRIBUTING.md guide, I updated it. ### Preview ### How to QA [^1] [^1]: Please use these labels when submitting a review: :question: #ask: Ask a question. :bulb: #idea: Suggest an idea. :warning: #issue: Strongly suggest a change. :tada: #nice: Share a compliment. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0188j8bZtppjZzgiM5snmz6k --------- Co-authored-by: Claude <noreply@anthropic.com>
Align the repository with prismicio/prismic-typescript-template: - Use Node.js 26 in CI and test on Node.js 22, 24, and 26. - Use actions/checkout@v7, actions/setup-node@v7, and googleapis/release-please-action@v5. - Test types against TypeScript 5, 6, and 7. - Require Node.js 22 or later. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0188j8bZtppjZzgiM5snmz6k
angeloashmore
force-pushed
the
claude/busy-archimedes-s3umeo-template
branch
from
September 18, 2026 19:40
099d73f to
7dc56b5
Compare
angeloashmore
marked this pull request as ready for review
September 18, 2026 19:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
Description
Aligns the repository with
prismicio/prismic-typescript-template. Stacked on top of #452.engines.nodeto>=22, because the updated toolchain requires it.actions/checkout@v7,actions/setup-node@v7,googleapis/release-please-action@v5.validate.ymlandpublish.ymlare now identical to the template, apart frombranches: [master]. The other config files already matched.Checklist
Preview
How to QA 1
🤖 Generated with Claude Code
https://claude.ai/code/session_0188j8bZtppjZzgiM5snmz6k
Note
Low Risk
CI-only workflow bumps and matrix changes; no runtime or application code is modified.
Overview
Aligns CI with the Prismic TypeScript template by upgrading GitHub Actions (
checkout/setup-nodev7,release-pleasev5) and running lint, build, publish, and type-check jobs on Node.js 26.Test coverage now includes Node 26 alongside 22 and 24. The TypeScript job matrix switches from pinned minors (5.4–5.9) to major lines 5, 6, and 7.
validate.ymlandpublish.ymlmatch the template aside from themasterbranch trigger.Reviewed by Cursor Bugbot for commit 7dc56b5. Bugbot is set up for automated code reviews on this repo. Configure here.
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩