Updated the complete “Speak with Your Hands” tutorial to use the modern ml5.js HandPose API.Speak with your hands 2.0#1509
Conversation
ksen0
left a comment
There was a problem hiding this comment.
A fe minor comments, but thanks so much for going through and updating everything! @doradocodes if you verify locally as well please feel free to merge.
There was a problem hiding this comment.
Hi @colemanliyah thanks for this wonderful work. I made some small comments throughout. Some of my comments apply to the subsequent examples too but I only noted it for the first instance of a change.
Also, the ml5.js style is to use a variable called hands rather than predictions. That might be a little friendlier to the reader, but it's also ok for this tutorial to have its own code style if you prefer to keep it as predictions.
Let me know if you have any questions!
|
Hi @colemanliyah I just noticed somethign weird is happening with your commit history (there are many unrelated changes that should not be in this PR) please be sure to rebase/cleanup history, or @ me if you need any help with that! |
82f3847 to
4414b8b
Compare
You're so right, sorry about that should be fixed now! Also, addressed your earlier comments in latest commit |
Resolves PR #1483 (#1483)
Replaced all older ml5 examples (ml5.handpose(), modelReady(), predict events, annotations) with the new API:
Updated every example sketch to work with the current ml5 version:
Embedded all example sketches directly into the tutorial using instead of linking out to external sketches.
Added updated comments and explanations to match the new code structure.
Updated explanations of prediction data to match the new HandPose output format (keypoints, keypoints3D, handedness, confidence).