Skip to content

Исправление check.yml: прогон в CI даже при FAILED завершался успешно. #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petrCher merged 2 commits into from
Sep 4, 2026
+4 −1
Merged

Исправление check.yml: прогон в CI даже при FAILED завершался успешно. #180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd4c49a
Исправлен checks.yml
CaseAsLimbo Sep 2, 2026
6ab7157
Починка шага Fail on pytest error
CaseAsLimbo Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,16 @@ jobs:
run: |
DB_DSN=postgresql://postgres@localhost:5432/postgres alembic upgrade head
- name: Build coverage file
id: pytest
run: |
DB_DSN=postgresql://postgres@localhost:5432/postgres pytest --junitxml=pytest.xml --cov-report=term-missing:skip-covered --cov=rating_api tests/ | tee pytest-coverage.txt
exit ${PIPESTATUS[0]}
Comment thread
CaseAsLimbo marked this conversation as resolved.
- name: Print report
if: always()
run: |
cat pytest-coverage.txt
- name: Pytest coverage comment
if: always()
uses: MishaKav/pytest-coverage-comment@main
with:
pytest-coverage-path: ./pytest-coverage.txt
Expand All @@ -50,7 +53,7 @@ jobs:
junitxml-path: ./pytest.xml
junitxml-title: Summary
- name: Fail on pytest errors
if: steps.pytest.outcome == 'failure'
if: failure() && steps.pytest.outcome == 'failure'
Comment thread
CaseAsLimbo marked this conversation as resolved.
run: exit 1
linting:
runs-on: ubuntu-latest
Expand Down
Loading