Repository navigation
Use default thumbnails as a fallback while real ones are loading - #3934
thatbudakguy wants to merge 1 commit into
Conversation
|
I upstreamed this from geoblacklight/geoblacklight#1970, since it didn't feel specific to GeoBlacklight. |
e4980e5 to
673c5a9
Compare
673c5a9 to
147c133
Compare
| grid-area: 1 / 1; | ||
| } | ||
|
|
||
| .thumbnail-fallback { |
There was a problem hiding this comment.
So, we're placing both images in one cell and only centering the fallback? If the default image is larger than the record image, parts of the default remain visible around the loaded image, right?
There was a problem hiding this comment.
That can't happen because we're always forcing the thumbnail to width: 100%; height: 100%, so if it renders at all, it will completely cover the fallback.
The behavior prior to this PR does allow thumbnails to not fully cover the container:
But after, they always cover:
There was a problem hiding this comment.
...realized this was from the earlier branch in GBL, and I forgot to port that part. great catch.
There was a problem hiding this comment.
Updated so that the real thumbnail is always at least as large as the fallback.
c6b00f3 to
605eea3
Compare
You can set default_thumbnail to a single value or a proc or method, which currently allows GeoBlacklight to render an icon thumbnail for every record based on its content type. This is pretty useful. This PR takes advantage of that in the case where we have both a default_thumbnail and the record has a thumbnail image of its own. In this case loading the thumbnail from an external location can sometimes be quite slow (if it's not cached yet) or even fail. This change just renders the default thumbnail with the record's real one stacked on top of it, so that the default gets used as a fallback while the loading happens, and stays there if the loading fails. The items are stacked using CSS, so there's no javascript needed to make it work.
605eea3 to
ee91242
Compare
You can set default_thumbnail to a single value or a proc or method,
which currently allows GeoBlacklight to render an icon thumbnail
for every record based on its content type. This is pretty useful.
This PR takes advantage of that in the case where we have both
a default_thumbnail and the record has a thumbnail image of its own.
In this case loading the thumbnail from an external location can
sometimes be quite slow (if it's not cached yet) or even fail.
This change just renders the default thumbnail with the record's
real one stacked on top of it, so that the default gets used as
a fallback while the loading happens, and stays there if the
loading fails. The items are stacked using CSS, so there's no
javascript needed to make it work.