Repository navigation
Isolate CONNECT headers from origin HTTPS responses - #18
Open
cursor[bot] wants to merge 3 commits into
Open
cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Reject CR/LF/NUL in CONNECT request lines so proxy_headers cannot smuggle extra headers. Parse CONNECT responses only through the header terminator, skip origin-semantic fields such as Set-Cookie and Content-Type, and never overwrite existing origin headers. Keep X-ProxyMesh-* visible on response.headers and store the full CONNECT set on request.meta['proxy_response_headers']. Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
Add a unit job to the existing proxy integration workflow so test_header_safety.py runs on ubuntu-24.04 without PROXY_URL. Pin the new checkout and setup-python actions by commit SHA. Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
Collaborator
|
bugbot review |
Author
|
Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings. |
processProxyResponse parsed only the latest TCP chunk, so a split CONNECT response dropped earlier header lines and could treat bytes after a split header terminator as headers. Co-authored-by: ProxyMesh AI <proxymeshai@users.noreply.github.com>
Author
|
Review found one bug, fixed in 4eaeec6.
No other correctness or security issues in the diff. The new unit job keeps |
proxymeshai
marked this pull request as ready for review
November 1, 2026 21:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CONNECT header issues from the vulnerability scan:
proxy_headerscannot smuggle extra headers.Set-Cookie,Content-Type,Location,Referrer-Policy, and similar) onto the HTTPS response, and do not overwrite headers the origin already sent.X-ProxyMesh-IPonresponse.headers.request.meta["proxy_response_headers"].Adds
test_header_safety.pyfor the CRLF and merge behavior. The Scrapy 2.17.0 floor for CVE-2026-84366 remains in #17.The existing proxy integration workflow runs
test_header_safety.pyin aunitjob onubuntu-24.04(noPROXY_URL). The new checkout and setup-python actions in that job are pinned by commit SHA. The integration job is unchanged.README, docs, and the agent skill describe which CONNECT headers are copied onto the response.