Implement registry version check script - #786
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019f8b54-076c-701a-863f-75106cd6f5bd Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f8b54-076c-701a-863f-75106cd6f5bd Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f8b91-2aa1-72c0-9046-7862234646fd Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019f8b91-2aa1-72c0-9046-7862234646fd Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com>
83fb1c3 to
7c1e2cc
Compare
|
This is cool - two things come to mind:
|
|
Yeah, I agree. I don't have a specific policy in mind but directionally I'm on board. To what degree should that be encoded into this script's report? We could augment this with more data than it currently gives. |
|
Also, we could extend this with a planner that makes it more obvious whether the discovered versions will even work together and suggest a batch. Something like:
For this batch, this would have discovered the 14 packages that work without me having to do a separate manual triage:
...this doesn't help with what you're describing, but maybe we can re-think this script such that it's a more useful swiss-army-knife for helping get the package sets updated with the best options when it can't be done automatically due to breaking changes. |
I to get us a good glance we could have:
Also I think we could be running this in a weekly cronjob thing in the Registry repo, opening an issue/PR if it finds something |
|
d283822 has some followups that address your points:
Tried it out with a live run against package set |
|
Latest commit is a prototype, still hacking on it a little. But as I was working on the version check script, I realized we could be doing a lot more automatically — and still safely — to update the package sets. Our current automatic upgrade is basically just "try all new packages in the last 24hrs, and if any fail, go sequentially and only include ones which succeed." Very naive, and if a package doesn't work in its 24h window for whatever reason it is never retried — even if it would work later on (such as a dependency finally upgrading). So the new prototype implements one shared planner that can be used by both the package set updater and the version check workflow. Any version of a package that's already in the set which is newer than what's in the set is eligible for any new plan, plus recently uploaded packages even if they've never been in the set. We restrict to a single compiler version but otherwise ignore ranges. We still try all packages first, but then we do bounded best-first latest/intermediate/current searches. The package set updater, if it is capable of finding a nonempty addition/upgrade plan, can just submit it. If it finds removals, downgrades, etc. then we can have that notify trustees for action, but it will never be automatically done. |
2a50471 to
e82da1b
Compare
Greptile SummaryThis PR adds a
Confidence Score: 5/5Safe to merge. The atomic-only API change is the biggest behavioral shift, but it is intentional, correctly implemented, and covered by a new unit test. The planner logic is sophisticated but well-tested with both synthetic and real-world (Elmish) fixtures. The new planner is a large addition, but every phase has targeted tests, the budget invariants are verified by the 'reserves the removal-analysis budget' test, and the real-world Elmish fixture confirms the algorithm on a case the author actually ran against package set 77. The API change from sequential to atomic is a deliberate tightening of the contract, and the updated test confirms the error path. No mismatches between types, codecs, or effect rows were found. Files Needing Attention: No files require special attention. The most complex new file is app/src/App/PackageSetPlanner.purs; its test coverage in app/test/App/PackageSetPlanner.purs is thorough.
|
| Filename | Overview |
|---|---|
| scripts/src/PackageSetVersionChecker.purs | New script: plans and reports compile-verified pending package set upgrades. Correctly passes Map.empty as additionSeeds to restrict candidates to existing-package upgrades, interprets all required effects, and guards the output path. |
| app/src/App/PackageSetPlanner.purs | New 5-phase greedy planner module. Budget split (maxPlanProbes=60, maxTotalProbes=100) is correct; infrastructure errors surface via EXCEPT; removal closure expansion is iterative and correctly terminates; validateCandidates rejects malformed inputs before probing. |
| app/src/App/API.purs | upgradeSequential replaced by upgradeAtomic — payload is now all-or-nothing. commitMessage correctly uses changeSet (equivalent to succeeded when atomic succeeds). Log message updated to use packageSetOperationCodec on the full operation rather than the inner data. |
| scripts/src/PackageSetUpdater.purs | Refactored from ad-hoc validatePackageSetCandidates / UpgradeSequential to the new 5-phase planner. Now waits for the job to complete (pollPackageSetJob) rather than returning after enqueueing. Effect row correctly extended with PACKAGE_SETS, STORAGE, RESOURCE_ENV. |
| app/test/App/PackageSetPlanner.purs | Comprehensive unit tests covering all 5 planner phases, budget enforcement, infrastructure-error isolation, and the Elmish real-world fixture. Removal analysis tests verify iterative closure expansion and correct updates map construction. |
| app/test/App/API.purs | New packageSetUpdateSpec test verifies that an atomically-failing update is rejected entirely (no writes, no mirrors) and the error message contains 'failed to compile atomically'. |
| .github/workflows/package-set-version-check.yml | New workflow (workflow_dispatch only). Correctly guards issue creation with hashFiles check (addressing the previous review comment). 120-minute timeout is reasonable given up to 100 full-set compile probes. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[PackageSetVersionChecker main] --> B[readLatestPackageSet]
B --> |Nothing| C[Log warn, return Nothing]
B --> |Just packageSet| D[plannerCandidates with empty additionSeeds]
D --> E[Planner.planUpgrades probeAtomic]
subgraph "5-Phase Planner"
E --> P1[Phase 1+2: probe all-latest, greedily drop offenders]
P1 --> P2[Phase 3: rescue each dropped candidate individually]
P2 --> P3[Phase 4: round-robin fallback to older versions]
P3 --> P4[Phase 5: probe interaction components]
P4 --> PR[Plan: verified + blocked + truncated]
end
PR --> F[Planner.analyzeRemovals]
subgraph "Removal Analysis"
F --> RA1[For each BlockedGroup: compute reverse-dep closure]
RA1 --> RA2[probe packageSet with removals + updates]
RA2 --> |Compiles| RA3[RemovalsVerified]
RA2 --> |Fails, new blockers| RA4[expand closure, retry]
RA2 --> |Fails, no progress| RA5[RemovalsUnverified]
RA4 --> RA2
end
F --> G[renderReport as Markdown]
G --> H{--output flag?}
H --> |Yes| I[Write to file]
H --> |No| J[Print to stdout only]
I --> K[Workflow: gh issue create]
Reviews (5): Last reviewed commit: "Merge commit '84b4028' into HEAD" | Re-trigger Greptile
34f73d7 to
1a035ef
Compare
Adds a compile-guided planner for package set upgrades in a dedicated module. The planner probes exact whole-set compiles and repairs failures greedily: it attributes compiler errors to the exact selected versions, drops implicated candidates, rescues over-dropped candidates, falls back to intermediate versions, and probes coordinated interaction components together. Blocked upgrades are analyzed for compile-verified removal closures that Registry Trustees can review. The package set updater submits the exact verified payload as one atomic operation, bound to the package set it was planned against via the new optional expectedBaseline field, which the server checks before applying an update. The version check script renders a Markdown report of pending upgrades: what will be applied automatically and what requires manual intervention, with ready-to-submit payloads and compiler evidence. A manually-dispatched workflow generates the report and opens an issue. Co-authored-by: Thomas Honeyman <admin@thomashoneyman.com> Amp-Thread-ID: https://ampcode.com/threads/T-019fc447-b7d9-7773-b47a-9b1dee18cb3b
1a035ef to
7fdca95
Compare
Closes #426 by adding a
.#version-checkscript to report registry versions newer than the versions in the latest package set. This reuses the package set updater candidate traversal instead of being brand-new.I ran the script against package set
77.13.1and found 19 pending versions. Not all of them can compile together, but 14 of them do, and that's submitted as purescript/registry#560.Five versions were intentionally left out:
barlow-lens@1.0.0breaksmorello@0.4.0, which uses the old Barlow API and declares<0.10.0.elmish@0.14.0breakselmish-hooks@0.11.0; meanwhile,elmish-html@0.12.0requires Elmish 0.14, so neither Elmish candidate can move until the dependent packages are compatible.hyrule@2.4.0removes modules still imported bybolson@0.3.9,deku@0.9.24, andocarina@1.5.4.node-child-process@12.0.0changes the exit API and breaksdotenv@4.0.3andnode-execa@5.0.0.So this is the point of the script: surface upgrades that automatic daily updates could not accept so maintainers can identify and submit a compatible coordinated batch.