Skip to content

MAINT: Move Ruff rule PT014 to per file ignores #4318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefan6419846 merged 1 commit into from
Oct 31, 2026
+1 −3
Merged

MAINT: Move Ruff rule PT014 to per file ignores #4318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ ignore = [
"PLW2901", # `with` statement variable `img` overwritten by assignment target
"PT011", # `pytest.raises(ValueError)` is too broad, set the `match`
"PT012", # `pytest.raises()` block should contain a single simple statement
"PT014", # Ruff bug: Duplicate of test case at index 1 in `@pytest_mark.parametrize`
"PTH123", # `open()` should be replaced by `Path.open()`
"RUF001", # Detect confusable Unicode-to-Unicode units. Introduces bugs
"RUF002", # Detect confusable Unicode-to-Unicode units. Introduces bugs
Expand Down Expand Up @@ -219,6 +218,7 @@ max-complexity = 31 # Recommended: 10
"make_release.py" = ["S603", "S607", "T201"]
"pypdf/*" = ["N802", "N803"] # We first need to deprecate old stuff
"tests/*" = ["ANN001", "ANN201", "B017", "B018", "D103", "D104", "S105", "S106"]
"tests/test_page.py" = ["PT014"] # Duplicate test cases in pytest.mark.parametrize
"tests/test_workflows.py" = ["T201"]

[tool.ruff.lint.pydocstyle]
Expand Down
2 changes: 0 additions & 2 deletions tests/test_generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,10 +1120,8 @@ def test_create_string_object_force():
("1.0", "1"),
("0.123000", "0.123"),
("0.000123000", "0.000123"),
("0.0", "0.0"),
("0", "0.0"),
("1", "1"),
("1.0", "1"),
("1.01", "1.01"),
("1.010", "1.01"),
("0000.0000", "0.0"),
Expand Down
Loading