Repository navigation
TST: Cover content stream renaming, scaling and merging of PageObject - #4338
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4338 +/- ##
==========================================
+ Coverage 98.67% 98.79% +0.12%
==========================================
Files 59 59
Lines 12114 12114
Branches 2304 2304
==========================================
+ Hits 11953 11968 +15
+ Misses 84 70 -14
+ Partials 77 76 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MartinThoma
force-pushed
the
tst/coverage-page
branch
from
November 2, 2026 12:20
dc5bce2 to
5dd769b
Compare
MartinThoma
marked this pull request as ready for review
November 2, 2026 12:21
stefan6419846
requested changes
Nov 2, 2026
Add tests for PageObject branches without coverage so far: * _content_stream_rename() with an inline image: renaming a color space resource called /G renames "/G cs", but keeps /CS /G in the inline image, where it means DeviceGray, * scale() of a page with a /VP viewport, given as array and as dictionary, * extract_text() passing text to visitor_text that is not terminated by an ET operator. Two strict xfail tests document bugs in merge_page(): * #4335: merging into a page whose /Annots is null silently drops the annotations of the merged page, * #3467: merging a page whose annotations were added with PdfWriter.add_annotation() raises TypeError: clone() creates the copy with self.__class__(), but Highlight, FreeText, ... have required keyword-only arguments. The open PRs #3785 and #4262 fix it. Where the expected behavior comes from ISO 32000-2:2020, the docstring names the section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MartinThoma
force-pushed
the
tst/coverage-page
branch
from
November 2, 2026 15:15
5dd769b to
b4b6b6d
Compare
stefan6419846
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for PageObject branches without coverage so far:
Two strict xfail tests document bugs in merge_page():
Where the expected behavior comes from ISO 32000-2:2020, the docstring names the section.