fix: reject empty components in wheel tags CLI - #700
Open
Pitchfork-and-Torch wants to merge 1 commit into
Open
Pitchfork-and-Torch wants to merge 1 commit into
Pitchfork-and-Torch wants to merge 1 commit into
Conversation
`--python-tag ''`, `py3..py2`, `+`, and trailing dots produced empty tag strings and invalid wheel names like `pkg-1.0..none-any.whl`. Raise ValueError when any split tag component is empty.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
==========================================
+ Coverage 63.45% 63.71% +0.25%
==========================================
Files 15 15
Lines 1267 1276 +9
==========================================
+ Hits 804 813 +9
Misses 463 463 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
-py3 can still leave the final tag set empty when py3 is the only original component. The input has no empty part, so this passes validation and later joins to an empty filename/tag component. Could _compute_tags() reject an empty result too, with a remove-last-tag test?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_compute_tagsaccepted'',py3..py2,+, trailing dots, etc., producing empty tag strings.pkg-1.0..none-any.whland emptyTag:headers.ValueErrorwhen any split tag component is empty.Test plan
test_compute_tags_rejects_empty_componentscp39,+py2, replace/remove) unchanged