Conversation
Wheel members copied from the build tree kept the umask in their zip mode, so the same sources produced different wheels. Executable files stay 755 and other files are stored as 644.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
==========================================
+ Coverage 63.54% 63.57% +0.02%
==========================================
Files 15 15
Lines 1270 1271 +1
==========================================
+ Hits 807 808 +1
Misses 463 463 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
The failing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #362
WheelFile.writestoredstat.S_IMODEfrom the build tree. That mode includes the process umask, so the same sources produced different wheels. Members are now stored as0644, or0755when any execute bit is set.Tests:
pytest tests/test_wheelfile.py::test_write_normalizes_umask