gh-136687: Add ./configure --with-curses to select the curses backend#153992
Merged
serhiy-storchaka merged 3 commits intoJul 19, 2026
Conversation
…ackend Add --with-curses=ncursesw|ncurses|curses|no, mirroring --with-readline. The default (auto) keeps the current behaviour: prefer ncursesw, fall back to ncurses. --with-curses=curses links the system's native curses (e.g. on NetBSD or Solaris), which has no pkg-config file and was previously unreachable; it is built with wide-character support when the library provides it. --without-curses excludes the curses and _curses_panel modules from the build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
July 18, 2026 14:53
Documentation build overview
6 files changed ·
|
The probe declared a wchar_t array whose subscript was mangled by m4 quoting, so it failed to compile and native curses was always detected as narrow. Use a wide string literal instead, with no brackets to quote. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ackend Detect the pkgsrc ncurses panel, which is installed as "gnupanel" (with a "gnu" prefix) so it does not clash with a system libpanel. Without this the panel search falls back to a mismatched system libpanel, and _curses_panel then operates on _curses windows from a different curses library and crashes. For the native "curses" backend, probe only the plain <curses.h>/<panel.h>: a system may also have ncurses headers, and picking those while linking the native library mixes incompatible declarations (e.g. tparm()) with the native <term.h>. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
enabled auto-merge (squash)
July 19, 2026 05:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--with-curses=ncursesw|ncurses|curses|no, mirroring--with-readline.The default (
auto) keeps the current behaviour: preferncursesw, fall back toncurses.--with-curses=curseslinks the system's native curses (for example on NetBSD or Solaris), which has no pkg-config file and was previously unreachable; it is built with wide-character support when the library provides it.--without-cursesexcludes thecursesand_curses_panelmodules from the build.This supersedes #136696, which added a boolean
--disable-curses:--without-cursescovers that request, and the option adds backend selection on top.