gh-154007: Improve test coverage for the shlex module#154009
Open
caseneuve wants to merge 1 commit into
Open
Conversation
tomasr8
reviewed
Jul 19, 2026
| s.push_token(tok) | ||
| mock_print.assert_called_once_with(f"shlex: pushing token {tok!r}") | ||
|
|
||
| def testPushSourceString(self): |
Member
There was a problem hiding this comment.
Wouldn't this already be covered by e.g. testPushToken?
Contributor
Author
There was a problem hiding this comment.
It exercises the debug path, originally I had one test setting debug, then split into 2 as there was a big gap in testing debug paths (without this one we go 91% -> 90%).
caseneuve
force-pushed
the
154007-improve-shlex-test-coverage
branch
from
July 19, 2026 11:00
8afc311 to
cf4df39
Compare
caseneuve
force-pushed
the
154007-improve-shlex-test-coverage
branch
from
July 19, 2026 11:03
cf4df39 to
8fa77b3
Compare
caseneuve
force-pushed
the
154007-improve-shlex-test-coverage
branch
from
July 19, 2026 11:12
8fa77b3 to
9b33e5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises statement coverage of
Lib/shlex.pyfrom 67% to 91%.Intentionally left out:
_print_tokens: only reachable viapython -m shlex, not public APIbreak/continuebranches deep inread_token()Closes #154007.
shlexmodule #154007