Skip to content

gh-158567: Workaround GCC crash in PyFloat_Pack2() #158568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Oct 1, 2026
Merged

gh-158567: Workaround GCC crash in PyFloat_Pack2() #158568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Objects/floatobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1907,10 +1907,20 @@ PyFloat_Pack2(double x, char *data, int le)
}

if ((_PY_FLOAT_LITTLE_ENDIAN && !le) || (_PY_FLOAT_BIG_ENDIAN && le)) {
#if defined(__s390x__) && defined(__GNUC__)
// gh-158567: Workaround GCC crash on s390x.
// Avoid __builtin_bswap16() with _Float16.
// https://bugzilla.redhat.com/show_bug.cgi?id=2544649
char buffer[2];
memcpy(buffer, &y, 2);
data[0] = buffer[1];
data[1] = buffer[0];
#else
Comment thread
skirpichev marked this conversation as resolved.
uint16_t word;
memcpy(&word, &y, 2);
word = _Py_bswap16(word);
memcpy(data, &word, 2);
#endif
}
else {
memcpy(data, &y, sizeof(_Float16));
Expand Down
Loading