Skip to content

fix: extend the pool of network errors caught during download - #727

Merged
joein merged 1 commit into
mainfrom
fix-hf-network-errors
Sep 24, 2026
Merged

joein merged 1 commit into
mainfrom
fix-hf-network-errors

Conversation

@joein

@joein joein commented Sep 24, 2026

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 6f10939b-99c5-4b77-b3bc-efdf743a7182

📥 Commits

Reviewing files that changed from the base of the PR and between a4616ae and d7eac20.

📒 Files selected for processing (1)
  • fastembed/common/model_management.py

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The change adds version-aware detection of httpx.TransportError and includes it in the errors caught by the Hugging Face download fallback. Existing OSError, RepositoryNotFoundError, and ValueError errors remain in the fallback exception set.

Estimated code review effort: 2 (Simple) | ~8 minutes

Suggested reviewers: he-yufeng

Merge Risk: ⚪ Minimal · up to d7eac

The fallback now catches Hugging Face Hub httpx transport failures, and compatibility checks found no merge-blocking issue.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so the description does not explain the download error-handling change. Add a brief description that explains which Hugging Face transport errors are now caught and why the fallback download logic requires this change.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: catching additional network errors during model downloads.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@joein
joein merged commit 09cab68 into main Sep 24, 2026
10 checks passed
@joein
joein deleted the fix-hf-network-errors branch September 24, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant