Repository navigation
Conversation
OPC (ECMA-376) treats package part names as case-insensitive. Archives whose central directory lists Word/Document.xml or XL/VBAProject.bin were left as application/x-tika-ooxml or a non-macro Office type. Downcase entry names before comparing them to the discriminating part list.
Author
|
The failing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OPC (ECMA-376) treats package part names as case-insensitive. ZIP central-directory refinement compared entry names with a case-sensitive
include?, so archives whose parts were stored asWord/Document.xmlorXL/VBAProject.binstayed onapplication/x-tika-ooxml(or a non-macro Office type) instead of refining to the document family.I downcase central-directory entry names before matching them against the discriminating part list, and keep that list in lowercase so the conventional
vbaProject.binspelling still matches.Test plan
bundle exec rake test(682 runs, 0 failures)