Skip to content

[5.x] Add isAddressComplete variable to addresses in cart - #1423

Open
Jade-GG wants to merge 2 commits into
masterfrom
feature/shippng-address-complete
Open

Jade-GG wants to merge 2 commits into
masterfrom
feature/shippng-address-complete

Conversation

@Jade-GG

@Jade-GG Jade-GG commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

ref: RAP-1976

This PR adds a .isAddressComplete into the addresses in your cart data to check whether an address is actually complete.

This can be used for the shipping and payment methods checks that shouldn't show up when the address is not yet filled up. Using uid doesn't (always) work for this, as the uid can absolutely be filled before any address data exists.

Comment on lines -1 to +4
import { StorageSerializers, asyncComputed, useLocalStorage, useMemoize } from '@vueuse/core'
import { StorageSerializers, useLocalStorage, useMemoize } from '@vueuse/core'
import { computed, watch } from 'vue'
import { GraphQLError } from '../fetch'
import { mask, clearMask } from './useMask'
import { clearMask, mask } from './useMask'

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were done automatically by my local prettier formatter.

@royduin

royduin commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Maybe customer_address_id could help here? See: RAP-1634. With RAP-1879 we're trying to get rid of the manual address comparison (#1430), now adding a address complete check doesn't feels like the right move. Maybe validate the form? From Magento it's possible to change show/hide and require fields, and then there are downloadable products which maybe do not require any address? Not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants