Conversation
Input strides were derived only from caps, so buffers with padded or non-default plane layouts were misinterpreted. Use the per-buffer GstVideoMeta strides and offsets on the memcpy path, programme the producer's strides for zero-copy where the layout is suitable, and fix the semi-planar copy path which assumed a planar U/V layout. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
BGR maps to the PiSP RGB888 format with the R/B swap CSC applied, the same memory layout as the existing DRM RG24 mapping. This allows the swap path to be exercised by the conversion tests. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
The harness can now rewrite an input asset with per-plane strides for either GStreamer or convert mode. Add strided YUV420P, YUYV and RGB888 cases with a new packed-stride YUV444P reference, plus BGR output variants that exercise the R/B swap CSC. Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.