[rtext] Check for empty strings in TextToPascal and TextToCamel - #6213
Merged
raysan5 merged 2 commits intoOct 4, 2026
Merged
Conversation
Owner
|
@Ne0nWinds please, could you add parenthesis to conditions, as per raylib code conentions, thanks |
Owner
|
@Ne0nWinds thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
TextToPascalandTextToCamelread past the end of empty strings (""). These are the only two text functions that don't handle this case.In both functions, the main for loop skips over index 0 and starts directly at index 1. This also inadvertently skips over the null-terminator check for index 0.
Solution: add a simple
text[0] != '\0'check before the main loop in each function.