Repository navigation
RDKEMW-27811 : [PLI]- [ROGERS IUV2][VIPA]Black Screen and Technical Fault Message on linear channel After Standby Wake-Up due to PlayerRequestTimeOut error - #314
Open
rekhap2kandhavelan wants to merge 3 commits into
Conversation
…re clearing a stale sinkbin reference could bypass the Rialto teardown sequence and leave its server-side session active. The teardown paths now request GST_STATE_NULL, confirm the transition with bounded state polling, remove the sinkbin from the pipeline, and then clear retained references. Test Procedure: updated in ticket Risks: medium Priority: P1 Signed-off-by: Rekha Kandhavelan rekha_kandhavelan@comcast.com
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
7 open issues
ConfigurePipeline()logs but continues reconfiguring the shared pipeline even though… · Newstd::mutexandstd::condition_variableare now part of this public struct, ensure this… · NewmTeardownInProgressis set at function entry, but clearing/notifying happens only at the bottom… · Newgst_element_get_state(). If it returns… · Newgst_element_set_state(..., NULL)fallback when… · Newif (current != GST_STATE_NULL)block is mis-indented relative to its surrounding scope, which… · NewpendingtoGST_STATE_NULLfor the initial `gst_element_get_state(...,… · New
What changed in this PR
Fixes sinkbin teardown ordering and synchronization to prevent stale Rialto sessions (and resulting black screen/technical fault) after standby wake-up by ensuring sinkbins reach GST_STATE_NULL before removal/cleanup, and by preventing pipeline reconfiguration while teardown is still releasing resources.
Changes:
- Add teardown synchronization (mutex/CV + in-progress flag) to coordinate
ConfigurePipeline()vsTearDownStream(). - Add bounded state polling after
gst_element_set_state(..., GST_STATE_NULL)and force reset if NULL isn’t reached. - Harden stale CC sinkbin cleanup paths and update the unit test to match the new teardown behavior.
| File | Description |
|---|---|
InterfacePlayerRDK.cpp |
Adds teardown synchronization + bounded state polling and improves stale sinkbin teardown before clearing references. |
InterfacePlayerPriv.h |
Introduces shared teardown mutex/CV/flag in GstPlayerPriv to gate pipeline reconfiguration. |
test/utests/tests/InterfacePlayerTests/InterfacePlayerFunctionTests.cpp |
Updates expectations to reflect additional gst_element_get_state() polling during teardown. |
Review effort: Lite
Comment on lines
+258
to
+260
| std::mutex mTeardownMutex; | ||
| std::condition_variable mTeardownCV; | ||
| bool mTeardownInProgress = false; |
Copilot stopped reviewing on behalf of
rekhap2kandhavelan due to an error
October 27, 2026 10:31
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A missing closing brace prevents compilation, while incomplete teardown synchronization still allows pipeline configuration to race with resource release.
5 open issues
std::mutexandstd::condition_variableare now part of this public struct, ensure this…
6 resolved since last review
ConfigurePipeline()logs but continues reconfiguring the shared pipeline even though…gst_element_set_state(..., NULL)fallback when…gst_element_get_state(). If it returns…mTeardownInProgressis set at function entry, but clearing/notifying happens only at the bottom…pendingtoGST_STATE_NULLfor the initial `gst_element_get_state(...,…if (current != GST_STATE_NULL)block is mis-indented relative to its surrounding scope, which…
Review effort: Balanced
Comment on lines
+426
to
+428
| std::unique_lock<std::mutex> teardownLock(interfacePlayerPriv->gstPrivateContext->mTeardownMutex); | ||
| if (!interfacePlayerPriv->gstPrivateContext->mTeardownCV.wait_for(teardownLock, std::chrono::milliseconds(3000), | ||
| [this]{ return !interfacePlayerPriv->gstPrivateContext->mTeardownInProgress; })) |
| { | ||
| MW_LOG_ERR("InterfacePlayerRDK::ConfigurePipeline: timed out waiting for prior TearDownStream to complete"); | ||
| } | ||
| } |
Comment on lines
+1593
to
+1595
| { | ||
| std::lock_guard<std::mutex> teardownLock(interfacePlayerPriv->gstPrivateContext->mTeardownMutex); | ||
| interfacePlayerPriv->gstPrivateContext->mTeardownInProgress = true; |
| { | ||
| { | ||
| std::lock_guard<std::mutex> teardownLock(interfacePlayerPriv->gstPrivateContext->mTeardownMutex); | ||
| interfacePlayerPriv->gstPrivateContext->mTeardownInProgress = true; |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
An unclosed lock scope prevents compilation, and incomplete teardown guards still allow pipeline configuration while teardown is active.
6 open issues
std::mutexandstd::condition_variableare now part of this public struct, ensure this…
Review effort: Balanced
Comment on lines
+2591
to
+2593
| GstStateChangeReturn nullRc = SetStateWithWarnings(GST_ELEMENT(stream->sinkbin), GST_STATE_NULL); | ||
|
|
||
| if (GST_STATE_CHANGE_FAILURE != nullRc) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change: This fix addresses a CC sinkbin teardown issue where clearing a stale sinkbin reference could bypass the Rialto teardown sequence and leave its server-side session active.
The teardown paths now request GST_STATE_NULL, confirm the transition with bounded state polling, remove the sinkbin from the pipeline, and then clear retained references.
Test Procedure: updated in ticket
Risks: medium
Priority: P1
Signed-off-by: Rekha Kandhavelan rekha_kandhavelan@comcast.com