Repository navigation
RDKEMW-27114 :When performing 30x FF of UHD VOD asset, playback screen exits at about 50% - #331
Merged
Merged
Conversation
…n exits at about 50% Reason for Change :Bug fixing Risks: Medium Priority: P1 Signed-off-by: Deepikasri Natarajan <deepikasri_n@comcast.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The premature-EOS guard lacks regression tests covering nonpositive PTS cleanup without EOS notification and unchanged positive PTS that should still notify EOS.
1 open issue
What changed in this PR
This PR addresses premature playback exit during 30× fast-forward of UHD VOD by preventing non-positive decoder timestamps from triggering end-of-stream inference.
Changes:
- Skip end-of-stream inference when the decoder PTS is zero or negative.
- Log the skipped check, clear its task ID, and remove the timeout source.
| File | Description |
|---|---|
| InterfacePlayerRDK.cpp | Adds a non-positive PTS guard to the decoder-based end-of-stream check. |
Review effort: Balanced
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The underflow timeout guard lacks regression tests confirming that non-positive PTS suppresses EOS, clears the task ID, and returns G_SOURCE_REMOVE, while unchanged positive PTS still triggers EOS.
1 open issue
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RDKEMW-27114 :When performing 30x FF of UHD VOD asset, playback screen exits at about 50%
Reason for Change :Prevent underflow-driven false EOS and premature playback completion during VOD forward trickplay
Risks: Medium
Priority: P1