Repository navigation
Conversation
Reason for change: None of the three task executors caught exceptions. A throwing task escaped the thread function and called std::terminate, killing the session-server process - and every session in it - with no error log. On the main thread a thrown exception also skipped the state->done signal, hanging any enqueueTaskAndWait waiter before termination. MainThread::mainThreadLoop, WorkerThread::taskHandler and EventThread::threadExecutor now catch std::exception and unknown exceptions, log them, and continue the loop. On the main thread the state->done signal still runs after a failed task so waiters are released. Test Procedure: Enqueue a throwing task on each executor; verify the process survives, the exception is logged, and enqueueTaskAndWait callers are released. Existing unit tests pass.
|
Pull request title must follow the pattern: Pull request description must follow the Commit message format for RDK-E:
< JIRA TICKET >: < one line summary of change less than 65 characters > |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for change:
None of the three task executors caught exceptions. A throwing task escaped the thread function and called std::terminate, killing the session-server process - and every session in it - with no error log. On the main thread a thrown exception also skipped the state->done signal, hanging any enqueueTaskAndWait waiter before termination.
MainThread::mainThreadLoop, WorkerThread::taskHandler and EventThread::threadExecutor now catch std::exception and unknown exceptions, log them, and continue the loop. On the main thread the state->done signal still runs after a failed task so waiters are released.
Test Procedure:
Enqueue a throwing task on each executor; verify the process survives, the exception is logged, and enqueueTaskAndWait callers are released. Existing unit tests pass.