Guard forced-native animations from JS updates (#57617)#57617
Closed
zeyap wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@zeyap has exported this pull request. If you are a Meta employee, you can view the originating Diff in D112822632. |
Summary: Prevent animation nodes from entering the JS update path when native driving is forced. If the invariant is violated, emit a one-time warning and stop before JS-driven reconciliation. Changelog: [Internal] Reviewed By: rubennorte Differential Revision: D112822632
meta-codesync
Bot
changed the title
|
This pull request has been merged in 49f0db4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Prevent animation nodes from entering the JS update path when native driving is forced. If the invariant is violated, emit a one-time warning and stop before JS-driven reconciliation.
Changelog: [Internal]
Reviewed By: rubennorte
Differential Revision: D112822632