Repository navigation
Deprecate ReplaceArgumentDefaultValue value object - #8690
Merged
TomasVotruba merged 1 commit intoOct 17, 2026
Merged
Conversation
TomasVotruba
enabled auto-merge (squash)
October 17, 2026 18:53
TomasVotruba
disabled auto-merge
October 17, 2026 18:53
TomasVotruba
deleted the
tv-deprecate-replace-argument-default-value-vo
branch
October 17, 2026 18:53
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8686.
The
@api used in rector-symfonynote onReplaceArgumentDefaultValuewas inaccurate - the value object is not referenced in rector-symfony (nor in any sibling package).Since the
ReplaceArgumentDefaultValueRectorrule that consumes it is already deprecated, this marks the value object@deprecatedtoo.The
ANY_VALUE_BEFOREsentinel was the only member still used by live code (ArgumentDefaultValueReplacer, which also serves the non-deprecatedFunctionArgumentDefaultValueReplacerRector). It is moved to the sharedReplaceArgumentDefaultValueInterfaceso live code no longer touches the deprecated class.