Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion rules/CodingStyle/ClassNameImport/ClassNameImportContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,21 @@ final class ClassNameImportContext
private array $usedImportTypes = [];

public function __construct(
private readonly AliasUsesResolver $aliasUsesResolver
private readonly AliasUsesResolver $aliasUsesResolver,
private readonly ShortNameResolver $shortNameResolver
) {
}

/**
* Short names actually used in the file (class-likes, names, docblock types) mapped to their FQN
*
* @return array<string, string>
*/
public function resolveShortNamesToFullyQualifiedNames(File $file): array
{
return $this->shortNameResolver->resolveFromFile($file);
}

/**
* @return string[]
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

use Nette\Utils\Strings;
use PhpParser\Node;
use Rector\CodingStyle\ClassNameImport\ShortNameResolver;
use Rector\CodingStyle\ClassNameImport\ClassNameImportContext;
use Rector\CodingStyle\Contract\ClassNameImport\ClassNameImportSkipVoterInterface;
use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType;
use Rector\ValueObject\Application\File;
Expand All @@ -23,15 +23,14 @@
final readonly class FullyQualifiedNameClassNameImportSkipVoter implements ClassNameImportSkipVoterInterface
{
public function __construct(
private ShortNameResolver $shortNameResolver
private ClassNameImportContext $classNameImportContext
) {
}

public function shouldSkip(File $file, FullyQualifiedObjectType $fullyQualifiedObjectType, Node $node): bool
{
// "new X" or "X::static()"
/** @var array<string, string> $shortNamesToFullyQualifiedNames */
$shortNamesToFullyQualifiedNames = $this->shortNameResolver->resolveFromFile($file);
$shortNamesToFullyQualifiedNames = $this->classNameImportContext->resolveShortNamesToFullyQualifiedNames($file);
$fullyQualifiedObjectTypeShortName = $fullyQualifiedObjectType->getShortName();
$className = $fullyQualifiedObjectType->getClassName();

Expand Down
Loading