Repository navigation
Re-offer Class_ node to rules after children traversed - #8836
Closed
TomasVotruba wants to merge 2 commits into
Closed
TomasVotruba wants to merge 2 commits into
TomasVotruba wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The rule traverser (
RectorNodeTraverser) is pre-order: aClass_rule runs before the class children are visited. So a rule whose precondition is only met by a descendant change - an emptied method body, or a rename that now duplicates animplements- cannot see it in a single traversal.Today this converges only because
FileProcessorre-runs the whole tree in a do-while loop until stable. That whole-tree reprint loop is the target of ongoing single-pass perf work; once it is dropped,Class_rules stop converging (e.g.RemoveEmptyClassMethodRectorleaves an empty constructor behind afterRemoveAlwaysTrueIfConditionRectorempties it).What
After a
Class_'s children are traversed, re-offer the class to its rules once, now that the children are settled. This substitutes the former whole-tree loop with a targeted, far cheaper step: it re-runs onlyClass_rules, only on classes, exactly once - instead of re-running every rule on every node until stable.Impact
mainas-is (do-while still present): no double-apply, no behavior change - full suite passes unchanged.Class_rules once the do-while loop is removed.bench/rerun_class_rectors_bench.phpisolates the added per-class cost; it is a fraction of one extra whole-tree pass.