Repository navigation
[Parallel] Report the error limit only when reached - #8844
Merged
TomasVotruba merged 1 commit intoOct 26, 2026
Merged
Conversation
Keep worker shutdown unchanged; derive its diagnostic flag from the error count. Amp-Thread-ID: https://ampcode.com/threads/T-01a16d84-bc27-70ae-85cc-28b404cfd024 Co-authored-by: Amp <amp@ampcode.com>
samsonasik
approved these changes
Oct 26, 2026
Member
|
Thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A worker timeout currently also reports
Reached system errors count limit of 50, even when processing just one file. The error callback sets the limit flag unconditionally.Set the flag from the actual error count. Workers still stop immediately, the command still fails, and the timeout and missing-results diagnostics remain unchanged.
The CLI regression covers both a single timeout below the limit and 49 syntax errors followed by a timeout that reaches it. It reuses the existing syntax-error fixtures. The original implementation fails the first case; an unconditional
falsefails the second.Validated on Linux with PHP 8.4.27:
composer complete-checkphp vendor/bin/phpunit tests/Bin tests/Parallel: 18 tests, 30 assertionsparallel-system-errors-limitandparallel-unfinished-jobsE2E testsNo change to worker shutdown or child-exit error accounting.
CI note
47 checks passed and one was skipped. The remaining
rector_laravel_rector_devfailure also occurs on the exact base commit, with the same fatal visibility error inDispatchToHelperFunctionsRector::getClassReflection():Both job logs resolve the same 62 package versions, including
rector/rector dev-main eda83bd. This workflow tests rector-laravel against the published Rector package and does not check out this PR source. No Laravel changes are included here.