Repository navigation
Remove BetterTokenIterator - #8856
Merged
TomasVotruba merged 1 commit intoOct 27, 2026
Merged
TomasVotruba merged 1 commit into
TomasVotruba merged 1 commit into
Conversation
Use TokenIterator from phpstan/phpdoc-parser: currentTokenIndex(), getTokenCount() and getContentBetween() replace currentPosition(), count() and printFromTo(). Only the Doctrine annotation parser checks the type of the next token. This check is now in NextTokenType. Amp-Thread-ID: https://ampcode.com/threads/T-01a17930-0285-73c5-a957-4325c77aa1b2
samsonasik
approved these changes
Oct 27, 2026
Member
|
Let's ship it 👍 Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
BetterTokenIterator. Rector now usesTokenIteratorfrom phpstan/phpdoc-parser.BetterTokenIteratorcurrentPosition()TokenIterator::currentTokenIndex()count()TokenIterator::getTokenCount()printFromTo()TokenIterator::getContentBetween()partialTokens(),isTokenTypeOnPosition(),containsTokenType()isNextTokenType(),isNextTokenTypes()NextTokenType::is(), used only by the Doctrine annotation parserTokenIteratorFactory::createFromTokenIterator()is also removed. It converted aTokenIteratorto aBetterTokenIterator.