Skip to content

RectorConfigBuilder methods with only optional parameters #9940

Closed

Description

@staabm

I wonder whether a configuration like

$config = RectorConfig::configure()
return $config->withComposerBased();

should emit a warning/error, because it does not enable anything. while withComposerBased declares all its parameters optional, IMO it does only make sense to use it with at least a single argument passed?

Activity

  1. TomasVotruba commented on Oct 26, 2026

    @TomasVotruba
    Member

    See existing PR addresing this 👍

  2. MadBox-99 commented on Oct 28, 2026

    @MadBox-99
  3. TomasVotruba commented on Oct 28, 2026

    @TomasVotruba
    Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions