Skip to content

fix(search): sort by relevance without query - #15

Merged
PascalRepond merged 2 commits into
rero:stagingfrom
PascalRepond:rep-default-sort
Nov 3, 2026
Merged

PascalRepond merged 2 commits into
rero:stagingfrom
PascalRepond:rep-default-sort

Conversation

@PascalRepond

Copy link
Copy Markdown
Contributor
  • Sort the browse links of the home page and the empty search by relevance, same as the searches with a query, instead of the oldest change date.

* Sort the browse links of the home page and the empty search by
  relevance, same as the searches with a query, instead of the oldest
  change date.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The Relevance sort option now defaults for searches with and without a query. The Date changed options no longer set the default for searches without a query. The comment clarifies that descending _score is the backend default in both cases.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Merge Risk: Minimal · up to b1c05

No actionable merge-blocking risk was identified in this focused sorting change.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "fix(search): sort by relevance without query" matches the change. The raw summary says the Relevance sort option now applies to empty searches, and the PR description says the home page bro…
Description check Passed The description states that the home page browse links and the empty search now sort by relevance instead of by oldest change date. This directly describes the change in src/app/app.routes.ts, which r…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(search): sort by relevance without query" matches the change. The raw summary says the Relevance sort option now applies to empty searches, and the PR description says the home page browse links and empty search now sort by relevance. The title names the main change and is specific, though it does not mention the home page browse links.

Full details: Description check

Explanation

The description states that the home page browse links and the empty search now sort by relevance instead of by oldest change date. This directly describes the change in src/app/app.routes.ts, which removes the no-query default from the Date changed options and makes Relevance the default for empty searches.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ef2c1ac4-5c39-4d50-8d18-0bcca66dc71d
Commits

Reviewing files that changed from the base of the PR and between 5725485 and b1c05e6.

Files selected for processing: 1
  • src/app/app.routes.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond
PascalRepond marked this pull request as draft November 3, 2026 12:46
@PascalRepond
PascalRepond marked this pull request as ready for review November 3, 2026 12:46
@PascalRepond
PascalRepond merged commit a020d21 into rero:staging Nov 3, 2026
3 checks passed
@PascalRepond
PascalRepond deleted the rep-default-sort branch November 3, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants