Repository navigation
Make shim boot path detection case-insensitive - #235
Open
Amodak9801 wants to merge 1 commit into
Open
Amodak9801 wants to merge 1 commit into
Amodak9801 wants to merge 1 commit into
Conversation
Firmware often stores SHIMX64.EFI, so strstr never sets is_shim and optional loader data is formatted incorrectly. Fixes rhboot#223 Signed-off-by: Amisha Modak <amodak@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Amodak9801
marked this pull request as draft
September 4, 2026 05:27
Amodak9801
marked this pull request as ready for review
September 4, 2026 05:30
Author
|
Gentle ping — this is ready for review when you have a moment. One-line change: |
Author
|
Gentle ping — still ready for review when you have a moment. One-line change: The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
show_var_path()detected shim with sequentialstrstr()on/File(\EFI\,\shim, and.efi). Firmware often rewrites the loader toSHIMX64.EFI, sois_shimstayed false and optional data was not formatted as a secondFile(...).strcasestr(we already build with_GNU_SOURCE) so uppercase and mixed-case paths match. Lowercaseshimx64.efiis unchanged.Fixes #223
Test plan
efibootmgr -vagainst an entry whose path isSHIMX64.EFI(or create\EFI\<distro>\shimx64.efiand let firmware uppercase it). Optional data should display asFile(...), not dotted UCS-2.shimx64.efientry still formats the same as before.grubx64.efi/GRUBX64.EFIis not treated as shim.I could not run
makein this environment (makeandefivardevel packages are not installed). The change is the one-linestrstr→strcasestrswap inshow_var_path().Made with Cursor