Having mkdumprd as a separate executable is a remnant fro the time before dracut existed. With the introduction of dracut most of the functionality of mkdumprd was removed and it became a simple wrapper for it. All the remaining functionality can also be done in a function called from kdumpctl. Same for mkfadumprd.
Turning mkdumprd/mkfadumprd into a function has the benefit that a lot of duplicate code can be avoided. For example handling of additional temporary directories. In addition the functions can access the OPT array and thus reduce the number of times kdump.conf needs to be parsed (See #139 ).
In addition, removing mkdumprd/mkfadumprd as stand alone executable reduces the chance of user errors. See [1] for example.
[1] https://bugzilla.redhat.com/show_bug.cgi?id=2032948
Having
mkdumprdas a separate executable is a remnant fro the time beforedracutexisted. With the introduction ofdracutmost of the functionality ofmkdumprdwas removed and it became a simple wrapper for it. All the remaining functionality can also be done in a function called fromkdumpctl. Same formkfadumprd.Turning
mkdumprd/mkfadumprdinto a function has the benefit that a lot of duplicate code can be avoided. For example handling of additional temporary directories. In addition the functions can access theOPTarray and thus reduce the number of timeskdump.confneeds to be parsed (See #139 ).In addition, removing
mkdumprd/mkfadumprdas stand alone executable reduces the chance of user errors. See [1] for example.[1] https://bugzilla.redhat.com/show_bug.cgi?id=2032948