Reject paths outside the repo root in repo drivers and AI file tools - #9723
Open
nishantmonu51 wants to merge 3 commits into
Open
Reject paths outside the repo root in repo drivers and AI file tools#9723nishantmonu51 wants to merge 3 commits into
nishantmonu51 wants to merge 3 commits into
Conversation
Collaborator
Author
|
@codex: review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc3a9b7d0a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
# Conflicts: # runtime/ai/develop_file.go
Collaborator
Author
|
@begelundmuller @k-anshul : can one of you review this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AI file tools (
read_file,write_file,develop_file) and the runtime's file APIs passed caller-supplied paths straight torepo.Get/Put/Delete, where both thefileandadmindrivers joined them onto the repo root with no containment check. A path with..segments (e.g./models/../../../../etc/passwd) could therefore read, write, or delete files outside the project root.drivers.ResolveRepoPath, which resolves a repo-relative path against the root and errors if the result escapes it. Both repo drivers now use it everywhere they previously didfilepath.Join(root, path)(Get,Hash,Stat,Put,MkdirAll,Rename,Delete)...segments up front, so the model gets a clear error instead of a filesystem error.ResolveRepoPath, traversal assertions in the shared repo driver test suite, and traversal cases for theread_fileandwrite_filetools.Checklist: