Stamp caller attribution (rillUserEmail, rillServiceToken) on the Druid query context - #9755
Open
mpasa wants to merge 1 commit into
Open
Stamp caller attribution (rillUserEmail, rillServiceToken) on the Druid query context#9755mpasa wants to merge 1 commit into
rillUserEmail, rillServiceToken) on the Druid query context#9755mpasa wants to merge 1 commit into
Conversation
Forward the calling user's email and service name from the metrics view's query_attributes to Druid's query context (as rillUserEmail/rillServiceToken), so they appear in Druid's query logs for attribution, similar to Imply Pivot's implyUserEmail. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
|
@codex: review |
Collaborator
|
@pjain1 : Can you help review this one ? |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
pjain1
reviewed
Jul 29, 2026
Comment on lines
+461
to
+462
| UserEmail string `json:"rillUserEmail,omitempty"` | ||
| ServiceToken string `json:"rillServiceToken,omitempty"` |
Member
There was a problem hiding this comment.
Instead of adding custom keys here, I would rather pass in key/values from stmt.QueryAttributes as it is so any arbitrary attributes you define in metrics view will be passed as it in Druid context. But this would either need a custom marshaller for DruidQueryContext or changing the struct to just a map.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stamps caller attribution on the query context of Druid SQL requests, similar to Imply Pivot's
implyUserEmail/implyViewTitle, so queries can be attributed to users in Druid's query logs.Statement.QueryAttributesto the query context:user_email→rillUserEmailandservice_token→rillServiceToken.query_attributes, e.g.:druidsqldriverpackage previously had none).Checklist:
Developed in collaboration with Claude Code