Skip to content

chore: migrate alerts, reports, public urls and personal files to i18n - #9775

Open
AdityaHegde wants to merge 1 commit into
mainfrom
chore/migrate-alerts-reports-public-urls-personal-files-to-i18n
Open

chore: migrate alerts, reports, public urls and personal files to i18n#9775
AdityaHegde wants to merge 1 commit into
mainfrom
chore/migrate-alerts-reports-public-urls-personal-files-to-i18n

Conversation

@AdityaHegde

Copy link
Copy Markdown
Collaborator

As part of complete migration to i18n this handles alerts, reports, public urls and personal files components

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@nishantmonu51

Copy link
Copy Markdown
Collaborator

@codex: review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df07a686d2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

{ year: "numeric", month: "short", day: "numeric" },
)}
{m.public_url_access_expires({
date: new Date($form.expiresAt).toLocaleDateString(undefined, {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Format the expiration date with the selected locale

When the app locale differs from the browser locale—for example, a Spanish-browser user explicitly selecting English—the undefined locale makes toLocaleDateString follow the browser instead of Paraglide's persisted selection, producing mixed-language text such as an English message with a Spanish-formatted date. Pass the current i18n locale (for example, from getLocale()) so the interpolated date matches the message language.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants