Skip to content

Allow host-specific view_image policies - #388

Merged
roackb2 merged 1 commit into
mainfrom
feat/view-image-default-prompt
Sep 8, 2026
Merged

roackb2 merged 1 commit into
mainfrom
feat/view-image-default-prompt

Conversation

@roackb2

@roackb2 roackb2 commented Sep 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • add a bounded ViewImageToolOptions.defaultPrompt fallback for view_image calls that omit prompt while preserving the existing coding-assistant default
  • add ViewImageToolOptions.sourcePolicy with paths-only, references-only, and paths-and-references modes
  • narrow the model-visible JSON parameters and execution validation consistently so disabled locator kinds cannot be invoked
  • require a resourceResolver whenever reference inputs are enabled, leaving TA to own authorization/reference resolution while Heddle enforces disabled source kinds

Verification

  • yarn vitest run src/tests/integration/tools/tools.test.ts --testNamePattern viewImageTool
  • yarn vitest run src/tests/unit/tools/external-context-contracts.test.ts
  • yarn tsc -p tsconfig.build.json --noEmit
  • yarn lint
  • yarn build

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-07T15:49:09.113249Z 77dc076 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@roackb2
roackb2 force-pushed the feat/view-image-default-prompt branch from 77dc076 to 3d84a97 Compare September 7, 2026 15:53
@roackb2 roackb2 changed the title Allow host-specific view_image default prompts Allow host-specific view_image policies Sep 7, 2026
@roackb2
roackb2 merged commit 61e0496 into main Sep 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant