Skip to content

fix(init): drop the docs workflow and starter descriptions - #848

Open
Adi-ty wants to merge 1 commit into
mainfrom
fix/init-generated-theme-hygiene
Open

Adi-ty wants to merge 1 commit into
mainfrom
fix/init-generated-theme-hygiene

Conversation

@Adi-ty

@Adi-ty Adi-ty commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Description

Themes generated from the starter no longer inherit the docs site workflow or the starter's descriptions. Mirrors rtCamp/plugin-elementary#95.

Technical Details

  • documentation.yml had no repository guard, so every generated theme inherited a GitHub Pages build and deploy job. Its build job now runs only in rtCamp/theme-elementary; deploy needs build, so it is skipped too. Init removes the file on first setup (STARTER_REPO_FILES), and .gitattributes export-ignores it so composer create-project leaves it out. tests/js/starter-files.test.js keeps the two lists in step.
  • The package.json, composer.json and style.css descriptions use the Elementary Theme name token, so init renames them. Previously generated themes shipped "A starter theme that facilitates…" and "A modern starter theme…", including in Appearance → Themes.
  • Docs: the init cleanup row, the README and skills cleanup notes, and the maintenance guide's cleanup checks and docs publishing section.

Checklist

  • Every .gitattributes export-ignore path is an init cleanup target on first setup; on re-init or --clean, a project's own documentation.yml is kept.
  • With the @rtcamp/wp-tooling 2.0.0 identity replacements, --name="Demo Site" turns all three descriptions into "Demo Site block theme, built on rtCamp theme-elementary."
  • actionlint passes on documentation.yml.
  • CI: npm run test:js (starter-files test) and the docs build on this PR.

Screenshots

N/A

To-do

  • Init still rewrites the starter's composer create-project commands (README.md, docs/getting-started.md) to the generated theme's own package, which does not exist on Packagist. That is left out of this PR: feat(init): add cleanup.replace and cleanup.unset wp-tooling#68 (cleanup.replace / cleanup.unset) adds what init needs, and the theme fix follows once it is merged.

Fixes/Covers issue

N/A

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings November 19, 2026 21:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants