Never type after-stabilization cleanup

[WaffleLapkin]

r? @JonathanBrouwer

[rustbot]

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

[JonathanBrouwer]

@bors try @rust-timer queue
Not expecting anything significant but just in case

[JonathanBrouwer]

Took me a bit to get through the diff in fallback.rs but I'm pretty sure I understand it and it's correct
r=me with neutral or better perf

View changes since this review

[rust-bors]

☀️ Try build successful (CI)
Build commit: 2143217 (2143217d6afb5b59bf6e45792d2aec53f9a8a53b)
Base parent: c241221 (c24122146bb8b9cfd9e5c067e0f736c59f5826a1)

[rust-timer]

Finished benchmarking commit (2143217): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.5%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.6%, -2.6%]	1
All ❌✅ (primary)	2.5%	[2.5%, 2.5%]	1

Cycles

Results (secondary 3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.8%	[2.2%, 5.9%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	3
All ❌✅ (primary)	-	-	0

Bootstrap: 474.908s -> 475.785s (0.18%)
Artifact size: 402.63 MiB -> 400.63 MiB (-0.50%)

[JonathanBrouwer]

@bors r+ rollup

[rust-bors]

📌 Commit 2a2ca58 has been approved by JonathanBrouwer

It is now in the queue for this repository.