fix(console): enforce protected API routing - #229
Merged
GatewayJ merged 2 commits intoAug 22, 2026
Conversation
GatewayJ
marked this pull request as ready for review
August 22, 2026 10:21
GatewayJ
force-pushed
the
agent/fix-1099-console-auth-boundary
branch
from
August 22, 2026 10:28
ad7de47 to
e8cad77
Compare
Member
Author
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Closes rustfs/backlog#1099
Summary of Changes
/sessionand all tenant, pool, pod, event, cluster, and topology APIs./sessionis protected while/logoutremains explicitly public.result_large_errclippy checks.The previous global middleware used request path strings as a fail-open allowlist, including every path outside
/api/v1. Router composition now defines the trust boundary, so newly added protected API routes cannot silently bypass authentication because of their path.Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](N/A: no changelog file exists in the repository)Impact
Verification
rustc --version # rustc 1.98.0 (88d9e12ae 2026-08-18) make pre-commitAdditional Notes
OPTIONSrequests continue to bypass session validation so browser CORS preflight behavior is preserved.Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.