fix: do not write console logs over the interactive TUI - #1909
Open
BradKollmyer wants to merge 2 commits into
Open
fix: do not write console logs over the interactive TUI#1909BradKollmyer wants to merge 2 commits into
BradKollmyer wants to merge 2 commits into
Conversation
Capture stderr logs while the TUI owns the terminal and print them after restoring cooked mode, so backend retry warnings cannot overwrite the progress popup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Backend retry warnings were written to stderr while
snapshots --interactivewas drawing the progress popup. In raw mode those writes overwrite the gauge, so a temporary B2 retry looks like a garbled crash.CLI progress already suspends indicatif via
PbPauseAppender. The TUI never did.Validation
cargo test --libforTuiLogCapture(inactive pass-through, capture until drop, nested guards, overflow, replay)cargo clippy --lib --tests -- -D warningsComplements rustic-rs/rustic_core#562, which stops OpenDAL retries from dumping a multi-line
Debugerror tree. This PR is independent of that change.