Repository navigation
Install biorbd and biobuddy in CI - #4
Merged
Merged
Conversation
The runner had no biobuddy, so the three build_biomod tests in tests/test_model_variants.py failed with ModuleNotFoundError. - set up conda (miniforge, conda-forge) with Python 3.11 and biorbd 1.11.2 - install biobuddy pinned at 85ec552 without dependencies, plus plotly - run steps through a login bash so the conda env is active Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Sort the imports in batch_run.py, pipeline_gui.py, tests/test_calibration_qc.py and tests/test_preview_frame_2d_render.py (isort 9.0.2, profile black) and wrap one over-long import in tests/test_preview_frame_2d_render.py (black). Formatting only, no behavior change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Résumé
Le runner de CI n'a pas
biobuddy: les trois testsbuild_biomoddetests/test_model_variants.pyéchouent avecModuleNotFoundError: No module named 'biobuddy'(c'est le cas surdevcomme sur les PR #2 et #3).Changements (
.github/workflows/ci.ymluniquement)setup-pythonparconda-incubator/setup-miniconda@v3(miniforge, canal conda-forge, Python 3.11) :biobuddyimportebiorbd, qui n'est pas installable depuis PyPI.biorbd=1.11.2(version deenvironment.vitpose-ekf.yml) via conda.biobuddyépinglé au commit85ec552(celui deenvironment.vitpose-ekf.yml, APIpelvis_height) avec--no-deps(biorbd vient de conda), plusplotlyavec ses dépendances (importé parbiobuddy).runpassent parbash -el {0}pour que l'environnement conda soit actif.setup-pythondisparaît ; pas d'autre changement dans les étapes de lint et de test.Vérification
biorbd=1.11.2),pip install -e .[test],pip install plotly,pip install --no-deps biobuddy@85ec552, puispytest -qsurdev: 430 passed, 3 skipped, 0 failed, contre 3 échecs sansbiobuddy.plotlyet ses dépendances (narwhals), l'import debiobuddyéchoue.Limites
biorbd).isortetblackéchouent toujours sur des fichiers antérieurs (batch_run.py,pipeline_gui.py,tests/test_calibration_qc.py,tests/test_preview_frame_2d_render.py) : non traité ici, la CI reste donc rouge tant que ces écarts de formatage existent.🤖 Generated with Claude Code